-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: update avatar and user components #1221
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DakEnviy
requested review from
DaffPunks,
LakeVostok,
amje,
ValeraS and
korvin89
as code owners
December 22, 2023 16:12
Preview is ready. |
Playwright Test Component is ready. |
DakEnviy
force-pushed
the
feat/new-avatar
branch
7 times, most recently
from
December 22, 2023 19:55
07895bd
to
8547906
Compare
DakEnviy
force-pushed
the
feat/new-avatar
branch
from
December 22, 2023 20:03
8547906
to
07dae4b
Compare
amje
requested changes
Dec 25, 2023
...hots__/Avatar.visual.test.tsx-snapshots/Avatar-render-story-ImageFallback-1-webkit-linux.png
Outdated
Show resolved
Hide resolved
DakEnviy
force-pushed
the
feat/new-avatar
branch
5 times, most recently
from
December 25, 2023 16:02
0b0ba33
to
3f30b1d
Compare
amje
requested changes
Dec 25, 2023
#{$block}_clickable:hover & { | ||
background-color: var(--g-color-base-generic); | ||
} | ||
#{$blockAvatar} { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to specify inner selector, we can put these vars inside &__avatar
DakEnviy
force-pushed
the
feat/new-avatar
branch
3 times, most recently
from
December 25, 2023 17:00
2a7942b
to
2225819
Compare
DakEnviy
force-pushed
the
feat/new-avatar
branch
4 times, most recently
from
December 26, 2023 16:03
f100a09
to
966a8d8
Compare
DakEnviy
force-pushed
the
feat/new-avatar
branch
from
December 27, 2023 15:02
966a8d8
to
f78dad6
Compare
amje
approved these changes
Dec 27, 2023
amje
changed the title
feat: update avatar and user components
feat!: update avatar and user components
Dec 27, 2023
amje
pushed a commit
that referenced
this pull request
Feb 1, 2024
amje
pushed a commit
that referenced
this pull request
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.